Fix logged notification count #4323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajagopalanand
force-pushed
the
notify-attempt-count
branch
from
bc3b721 to
c1b6658
Compare
notify/notify.go
Outdated
| @@ -848,6 +848,7 @@ func (r RetryStage) exec(ctx context.Context, l *slog.Logger, alerts ...*types.A | |||
| default: | |||
| } | |||
|
|
|||
| i++ | |||
There was a problem hiding this comment.
Doesn't this mean that if Line 844 is true, the error message contains 0 attempts, which is incorrect?
There was a problem hiding this comment.
The very first attempt to send notification only happens on line 855. Even if 844 were true, and it contains 0 attempts, I think that is correct.
Correct me if I'm wrong
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand
force-pushed
the
notify-attempt-count
branch
from
c1b6658 to
62deeb6
Compare
grobinson-grafana
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple fix to correct the log message. In cases where context cancelation occurs, the logs show notification was attempted twice when in fact it was only attempted once